Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHINENG-11257: fix attributeFilter parsing for string value #1454

Merged
merged 2 commits into from
Jul 12, 2024
Merged

RHINENG-11257: fix attributeFilter parsing for string value #1454

merged 2 commits into from
Jul 12, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Jul 11, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking Jira Linking
Copy link

jira-linking bot commented Jul 11, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-11257

@psegedy psegedy requested a review from MichaelMraka July 11, 2024 07:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.81%. Comparing base (e6fd838) to head (893ec7d).
Report is 26 commits behind head on master.

Files Patch % Lines
manager/middlewares/rbac.go 73.33% 3 Missing and 1 partial ⚠️
base/rbac/rbac.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
+ Coverage   63.91%   64.81%   +0.90%     
==========================================
  Files         113      114       +1     
  Lines        6961     7777     +816     
==========================================
+ Hits         4449     5041     +592     
- Misses       1990     2206     +216     
- Partials      522      530       +8
Flag Coverage Δ
unittests 64.81% <80.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy marked this pull request as draft July 11, 2024 07:40
@psegedy psegedy marked this pull request as ready for review July 11, 2024 10:16
@psegedy
Copy link
Member Author

psegedy commented Jul 11, 2024

content-source/pulp deploy fails

@psegedy
Copy link
Member Author

psegedy commented Jul 11, 2024

/retest

@psegedy psegedy merged commit 4606ea9 into RedHatInsights:master Jul 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMraka MichaelMraka MichaelMraka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psegedy @codecov-commenter @MichaelMraka